Author: kostat
Date: 2006-12-17 12:55:04 -0500 (Sun, 17 Dec 2006)
New Revision: 69624

Modified:
   
trunk/mcs/class/System.Data/System.Data.ProviderBase.jvm/AbstractDBParameter.cs
   
trunk/mcs/class/System.Data/Test/ProviderTests/System.Data.OleDb.jvm/OleDbParameterCollection/OleDbParameterCollection_Add.cs
Log:
Nullify parent when cloning the parameters

Modified: 
trunk/mcs/class/System.Data/System.Data.ProviderBase.jvm/AbstractDBParameter.cs
===================================================================
--- 
trunk/mcs/class/System.Data/System.Data.ProviderBase.jvm/AbstractDBParameter.cs 
    2006-12-17 17:44:07 UTC (rev 69623)
+++ 
trunk/mcs/class/System.Data/System.Data.ProviderBase.jvm/AbstractDBParameter.cs 
    2006-12-17 17:55:04 UTC (rev 69624)
@@ -263,8 +263,10 @@
                protected internal abstract void SetSpecialFeatures(ResultSet 
res);
                
                public virtual object Clone()
-               {
-                       return MemberwiseClone();
+               {
+                       AbstractDbParameter other = (AbstractDbParameter) 
MemberwiseClone ();
+                       other._parent = null;
+                       return other;
                }
 
                protected internal abstract int JdbcTypeFromProviderType();

Modified: 
trunk/mcs/class/System.Data/Test/ProviderTests/System.Data.OleDb.jvm/OleDbParameterCollection/OleDbParameterCollection_Add.cs
===================================================================
--- 
trunk/mcs/class/System.Data/Test/ProviderTests/System.Data.OleDb.jvm/OleDbParameterCollection/OleDbParameterCollection_Add.cs
       2006-12-17 17:44:07 UTC (rev 69623)
+++ 
trunk/mcs/class/System.Data/Test/ProviderTests/System.Data.OleDb.jvm/OleDbParameterCollection/OleDbParameterCollection_Add.cs
       2006-12-17 17:55:04 UTC (rev 69624)
@@ -82,5 +82,15 @@
                        catch(Exception ex){exp = ex;}
                        finally{EndCase(exp); exp = null;}
                }
+               
+               [Test]
+               public void TestAddCloned()
+               {
+                       OleDbCommand c = new OleDbCommand ();
+                       OleDbParameter p = c.Parameters.Add ("SDF", 
OleDbType.BigInt);
+                       OleDbCommand c1 = new OleDbCommand ();
+                       c1.Parameters.Add ((OleDbParameter) ((ICloneable) 
p).Clone ());
+                       Assert.AreEqual(1, c1.Parameters.Count, "#01");
+               }
        }
 }
\ No newline at end of file

_______________________________________________
Mono-patches maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches

Reply via email to