Author: jpobst
Date: 2007-03-28 14:31:15 -0500 (Wed, 28 Mar 2007)
New Revision: 75102

Modified:
   trunk/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ChangeLog
   trunk/mcs/class/Managed.Windows.Forms/System.Windows.Forms/Control.cs
Log:
2007-03-28  Jonathan Pobst  <[EMAIL PROTECTED]>

        * Control.cs: We need to call OnVisibleChanged for our implicit
        children as well as our normal children.  Fixes scrollbars in
        comboboxes not showing up.

Modified: trunk/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ChangeLog
===================================================================
--- trunk/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ChangeLog        
2007-03-28 19:25:53 UTC (rev 75101)
+++ trunk/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ChangeLog        
2007-03-28 19:31:15 UTC (rev 75102)
@@ -1,5 +1,11 @@
 2007-03-28  Jonathan Pobst  <[EMAIL PROTECTED]>
 
+       * Control.cs: We need to call OnVisibleChanged for our implicit
+       children as well as our normal children.  Fixes scrollbars in
+       comboboxes not showing up.
+
+2007-03-28  Jonathan Pobst  <[EMAIL PROTECTED]>
+
        * Control.cs, Form.cs: Anywhere we call CreateHandle, we need to do
        the check for IsHandleCreated first.  The check in CreateHandle is not
        good enough because CreateHandle can be overriden, and the override 

Modified: trunk/mcs/class/Managed.Windows.Forms/System.Windows.Forms/Control.cs
===================================================================
--- trunk/mcs/class/Managed.Windows.Forms/System.Windows.Forms/Control.cs       
2007-03-28 19:25:53 UTC (rev 75101)
+++ trunk/mcs/class/Managed.Windows.Forms/System.Windows.Forms/Control.cs       
2007-03-28 19:31:15 UTC (rev 75102)
@@ -5660,12 +5660,10 @@
                        if (eh != null)
                                eh (this, e);
 
-                       // We need to tell our kids
-                       for (int i=0; i<child_controls.Count; i++) {
-                               if (child_controls[i].Visible) {
-                                       
child_controls[i].OnParentVisibleChanged(e);
-                               }
-                       }
+                       // We need to tell our kids (including implicit ones)
+                       foreach (Control c in Controls.GetAllControls ())
+                               if (c.Visible)
+                                       c.OnParentVisibleChanged (e);
                }
                #endregion      // OnXXX methods
 

_______________________________________________
Mono-patches maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches

Reply via email to