Author: zoltan
Date: 2007-04-01 15:18:08 -0400 (Sun, 01 Apr 2007)
New Revision: 75264

Modified:
   trunk/mono/mono/metadata/ChangeLog
   trunk/mono/mono/metadata/threads.c
Log:
2007-04-01  Zoltan Varga  <[EMAIL PROTECTED]>

        * threads.c (abort_appdomain_thread): Avoid handle leakage if we are
        waiting for too many threads.


Modified: trunk/mono/mono/metadata/ChangeLog
===================================================================
--- trunk/mono/mono/metadata/ChangeLog  2007-04-01 15:50:48 UTC (rev 75263)
+++ trunk/mono/mono/metadata/ChangeLog  2007-04-01 19:18:08 UTC (rev 75264)
@@ -1,3 +1,8 @@
+2007-04-01  Zoltan Varga  <[EMAIL PROTECTED]>
+
+       * threads.c (abort_appdomain_thread): Avoid handle leakage if we are
+       waiting for too many threads.
+
 2007-03-28  Sebastien Pouliot  <[EMAIL PROTECTED]>
 
        * environment.c: Fix return value check on uname so we can get the 

Modified: trunk/mono/mono/metadata/threads.c
===================================================================
--- trunk/mono/mono/metadata/threads.c  2007-04-01 15:50:48 UTC (rev 75263)
+++ trunk/mono/mono/metadata/threads.c  2007-04-01 19:18:08 UTC (rev 75264)
@@ -2348,15 +2348,14 @@
        MonoDomain *domain = data->domain;
 
        if (mono_thread_has_appdomain_ref (thread, domain)) {
-               HANDLE handle = OpenThread (THREAD_ALL_ACCESS, TRUE, 
thread->tid);
-               if (handle == NULL)
-                       return;
-
                /* printf ("ABORTING THREAD %p BECAUSE IT REFERENCES DOMAIN 
%s.\n", thread->tid, domain->friendly_name); */
 
                ves_icall_System_Threading_Thread_Abort (thread, NULL);
 
                if(data->wait.num<MAXIMUM_WAIT_OBJECTS) {
+                       HANDLE handle = OpenThread (THREAD_ALL_ACCESS, TRUE, 
thread->tid);
+                       if (handle == NULL)
+                               return;
                        data->wait.handles [data->wait.num] = handle;
                        data->wait.threads [data->wait.num] = thread;
                        data->wait.num++;

_______________________________________________
Mono-patches maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches

Reply via email to