Author: msierad
Date: 2007-05-15 18:10:53 -0400 (Tue, 15 May 2007)
New Revision: 77442

Modified:
   
trunk/mcs/class/Microsoft.Build.Utilities/Test/Microsoft.Build.Utilities/ChangeLog
   
trunk/mcs/class/Microsoft.Build.Utilities/Test/Microsoft.Build.Utilities/CommandLineBuilderTest.cs
Log:
2007-05-16  Marek Sieradzki  <[EMAIL PROTECTED]>

        * CommandLineBuilderTest.cs: Added tests for filenames that contain
        spaces.



Modified: 
trunk/mcs/class/Microsoft.Build.Utilities/Test/Microsoft.Build.Utilities/ChangeLog
===================================================================
--- 
trunk/mcs/class/Microsoft.Build.Utilities/Test/Microsoft.Build.Utilities/ChangeLog
  2007-05-15 21:19:18 UTC (rev 77441)
+++ 
trunk/mcs/class/Microsoft.Build.Utilities/Test/Microsoft.Build.Utilities/ChangeLog
  2007-05-15 22:10:53 UTC (rev 77442)
@@ -1,3 +1,8 @@
+2007-05-16  Marek Sieradzki  <[EMAIL PROTECTED]>
+
+       * CommandLineBuilderTest.cs: Added tests for filenames that contain
+       spaces.
+
 2006-12-19  Marek Sieradzki  <[EMAIL PROTECTED]>
 
        * CommandLineBuilderTest.cs, TaskItemTest.cs: More tests.

Modified: 
trunk/mcs/class/Microsoft.Build.Utilities/Test/Microsoft.Build.Utilities/CommandLineBuilderTest.cs
===================================================================
--- 
trunk/mcs/class/Microsoft.Build.Utilities/Test/Microsoft.Build.Utilities/CommandLineBuilderTest.cs
  2007-05-15 21:19:18 UTC (rev 77441)
+++ 
trunk/mcs/class/Microsoft.Build.Utilities/Test/Microsoft.Build.Utilities/CommandLineBuilderTest.cs
  2007-05-15 22:10:53 UTC (rev 77442)
@@ -100,6 +100,13 @@
                        clb.AppendFileNameIfNotNull (item);
                        
                        Assert.AreEqual (itemSpec, clb.ToString (), "A1");
+
+                       item = new TaskItem ();
+                       item.ItemSpec = itemSpec = "a b";
+                       clb = new CommandLineBuilder ();
+                       clb.AppendFileNameIfNotNull (item);
+
+                       Assert.AreEqual ("\"" + itemSpec + "\"", clb.ToString 
(), "A2");
                }
                
                [Test]
@@ -108,11 +115,16 @@
                        
                        string filename = "filename.txt";
                        
-                       clb = new CommandLineBuilder ();
-                       
+                       clb = new CommandLineBuilder ();        
                        clb.AppendFileNameIfNotNull (filename);
                        
                        Assert.AreEqual (filename, clb.ToString (), "A1");
+
+                       filename = "a b";
+                       clb = new CommandLineBuilder ();
+                       clb.AppendFileNameIfNotNull (filename);
+
+                       Assert.AreEqual ("\"" + filename + "\"", clb.ToString 
(), "A2");
                }
 
                [Test]
@@ -162,6 +174,11 @@
                        clb.AppendFileNamesIfNotNull ((string[]) null, "sep");
                        
                        Assert.AreEqual ("a\tb\tc", clb.ToString (), "A3");
+
+                       clb = new CommandLineBuilder ();
+                       clb.AppendFileNamesIfNotNull (new string [] { "a", "b 
c"}, " ");
+
+                       Assert.AreEqual ("a \"b c\"", clb.ToString (), "A4");
                }
                
                [Test]
@@ -185,6 +202,11 @@
                        clb.AppendFileNamesIfNotNull ((ITaskItem[]) null, 
"sep");
                        
                        Assert.AreEqual ("ab", clb.ToString (), "A2");
+
+                       clb = new CommandLineBuilder ();
+                       clb.AppendFileNamesIfNotNull (new ITaskItem [] { new 
TaskItem ("a"), new TaskItem ("b c") }, " ");
+
+                       Assert.AreEqual ("a \"b c\"", clb.ToString (), "A3");
                }
 
                [Test]
@@ -523,18 +545,18 @@
                {
                        CLBTester clbt = new CLBTester ();
 
-                       Assert.AreEqual (false, clbt.IsQuotingRequired(""), 
"A1");
-                       Assert.AreEqual (true, clbt.IsQuotingRequired(" "), 
"A2");
-                       Assert.AreEqual (false, clbt.IsQuotingRequired("a"), 
"A3");
-                       Assert.AreEqual (true, clbt.IsQuotingRequired("a a"), 
"A4");
-                       Assert.AreEqual (true, clbt.IsQuotingRequired("\'\'"), 
"A5");
-                       Assert.AreEqual (true, clbt.IsQuotingRequired("\' \'"), 
"A6");
-                       Assert.AreEqual (true, clbt.IsQuotingRequired("\"\""), 
"A7");
-                       Assert.AreEqual (true, clbt.IsQuotingRequired("\" \""), 
"A8");
-                       Assert.AreEqual (true, clbt.IsQuotingRequired("\n\n"), 
"A9");
-                       Assert.AreEqual (true, clbt.IsQuotingRequired("\n \n"), 
"A10");
-                       Assert.AreEqual (true, clbt.IsQuotingRequired("\t\t"), 
"A11");
-                       Assert.AreEqual (true, clbt.IsQuotingRequired("\t \t"), 
"A12");
+                       Assert.AreEqual (false, clbt.IsQuotingRequired (""), 
"A1");
+                       Assert.AreEqual (true, clbt.IsQuotingRequired (" "), 
"A2");
+                       Assert.AreEqual (false, clbt.IsQuotingRequired ("a"), 
"A3");
+                       Assert.AreEqual (true, clbt.IsQuotingRequired ("a a"), 
"A4");
+                       Assert.AreEqual (true, clbt.IsQuotingRequired ("\'\'"), 
"A5");
+                       Assert.AreEqual (true, clbt.IsQuotingRequired ("\' 
\'"), "A6");
+                       Assert.AreEqual (true, clbt.IsQuotingRequired ("\"\""), 
"A7");
+                       Assert.AreEqual (true, clbt.IsQuotingRequired ("\" 
\""), "A8");
+                       Assert.AreEqual (true, clbt.IsQuotingRequired ("\n\n"), 
"A9");
+                       Assert.AreEqual (true, clbt.IsQuotingRequired ("\n 
\n"), "A10");
+                       Assert.AreEqual (true, clbt.IsQuotingRequired ("\t\t"), 
"A11");
+                       Assert.AreEqual (true, clbt.IsQuotingRequired ("\t 
\t"), "A12");
                }
 
                [Test]

_______________________________________________
Mono-patches maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches

Reply via email to