Author: bnickel
Date: 2007-06-20 17:12:06 -0400 (Wed, 20 Jun 2007)
New Revision: 80366
Modified:
trunk/taglib-sharp/ChangeLog
trunk/taglib-sharp/src/TagLib/Asf/Tag.cs
trunk/taglib-sharp/src/TagLib/Mpeg4/AppleTag.cs
trunk/taglib-sharp/src/TagLib/Tag.cs
Log:
2007-06-20 Brian Nickel <[EMAIL PROTECTED]>
* src/TagLib/Mpeg4/AppleTag.cs:
* src/TagLib/Asf/Tag.cs: Don't return Performers if AlbumArtists is not
found. This, provided with the second to last commit should resolve
inconsistancies in the behaviour. (Thanks to JustinC for the bug
report, otherwise that travesty that is the previous implementation may
have gone on forever.)
* src/TagLib/Tag.cs: Fix typos.
Modified: trunk/taglib-sharp/ChangeLog
===================================================================
--- trunk/taglib-sharp/ChangeLog 2007-06-20 20:53:43 UTC (rev 80365)
+++ trunk/taglib-sharp/ChangeLog 2007-06-20 21:12:06 UTC (rev 80366)
@@ -1,5 +1,16 @@
2007-06-20 Brian Nickel <[EMAIL PROTECTED]>
+ * src/TagLib/Mpeg4/AppleTag.cs:
+ * src/TagLib/Asf/Tag.cs: Don't return Performers if AlbumArtists is not
+ found. This, provided with the second to last commit should resolve
+ inconsistancies in the behaviour. (Thanks to JustinC for the bug
+ report, otherwise that travesty that is the previous implementation may
+ have gone on forever.)
+
+ * src/TagLib/Tag.cs: Fix typos.
+
+2007-06-20 Brian Nickel <[EMAIL PROTECTED]>
+
* src/TagLib/Id3v2/Frames/UnsynchronisedLyricsFrame.cs:
* src/TagLib/Id3v2/Frames/RelativeVolumeFrame.cs:
* src/TagLib/Id3v2/Frames/CommentsFrame.cs:
Modified: trunk/taglib-sharp/src/TagLib/Asf/Tag.cs
===================================================================
--- trunk/taglib-sharp/src/TagLib/Asf/Tag.cs 2007-06-20 20:53:43 UTC (rev
80365)
+++ trunk/taglib-sharp/src/TagLib/Asf/Tag.cs 2007-06-20 21:12:06 UTC (rev
80366)
@@ -95,18 +95,9 @@
set {description.Title = value;}
}
- // This may seem unintuitive, but the artists field is actually
- // performers. This makes sense as Artists should descibe the album
- // artist and Performers should describe who is in the song.
- // Because this may not be set, we'll return performers if we can't get
- // an artist.
public override string [] AlbumArtists
{
- get
- {
- string value = GetDescriptorString ("WM/AlbumArtist",
"AlbumArtist");
- return (value != null) ? SplitAndClean (value) : Performers;
- }
+ get {return GetDescriptorStrings ("WM/AlbumArtist", "AlbumArtist");}
set {SetDescriptorStrings (value, "WM/AlbumArtist", "AlbumArtist");}
}
Modified: trunk/taglib-sharp/src/TagLib/Mpeg4/AppleTag.cs
===================================================================
--- trunk/taglib-sharp/src/TagLib/Mpeg4/AppleTag.cs 2007-06-20 20:53:43 UTC
(rev 80365)
+++ trunk/taglib-sharp/src/TagLib/Mpeg4/AppleTag.cs 2007-06-20 21:12:06 UTC
(rev 80366)
@@ -215,11 +215,7 @@
public override string [] AlbumArtists
{
- get
- {
- string [] text = GetText(BoxType.Aart);
- return text.Length > 0 ? text : Performers;
- }
+ get {return GetText (BoxType.Aart);}
set { SetText(BoxType.Aart, value); }
}
Modified: trunk/taglib-sharp/src/TagLib/Tag.cs
===================================================================
--- trunk/taglib-sharp/src/TagLib/Tag.cs 2007-06-20 20:53:43 UTC (rev
80365)
+++ trunk/taglib-sharp/src/TagLib/Tag.cs 2007-06-20 21:12:06 UTC (rev
80366)
@@ -75,7 +75,7 @@
public string FirstComposer { get { return FirstInGroup(Composers);
} }
public string FirstGenre { get { return FirstInGroup(Genres);
} }
- [Obsolete("For album artists use FirstAlbumArtist. For track artists,
use FirstPerformer")]
+ [Obsolete("For album artists use JoinedAlbumArtists. For track artists,
use JoinedPerformers")]
public string JoinedArtists { get { return JoinedPerformers;} }
public string JoinedAlbumArtists { get { return
JoinGroup(AlbumArtists);} }
public string JoinedPerformers { get { return JoinGroup(Performers);
} }
_______________________________________________
Mono-patches maillist - [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches
