Author: rolf
Date: 2007-11-01 10:19:36 -0500 (Thu, 01 Nov 2007)
New Revision: 88652

Modified:
   trunk/moon/plugin/ChangeLog
   trunk/moon/plugin/downloader.cpp
Log:
* downloader.cpp: Don't keep a ref to the Downloader, it causes a
  circular reference.

Modified: trunk/moon/plugin/ChangeLog
===================================================================
--- trunk/moon/plugin/ChangeLog 2007-11-01 14:46:00 UTC (rev 88651)
+++ trunk/moon/plugin/ChangeLog 2007-11-01 15:19:36 UTC (rev 88652)
@@ -1,3 +1,8 @@
+2007-11-01  Rolf Bjarne Kvinge <[EMAIL PROTECTED]> 
+
+       * downloader.cpp: Don't keep a ref to the Downloader, it causes a 
circular
+         reference.
+
 2007-10-31  Andrew Jorgensen  <[EMAIL PROTECTED]>
 
        * Makefile.am: Don't link in cairo, pixman, or anything else that we

Modified: trunk/moon/plugin/downloader.cpp
===================================================================
--- trunk/moon/plugin/downloader.cpp    2007-11-01 14:46:00 UTC (rev 88651)
+++ trunk/moon/plugin/downloader.cpp    2007-11-01 15:19:36 UTC (rev 88652)
@@ -30,7 +30,11 @@
                this->npp = NULL;
                this->stream = NULL;
                
-               base_ref (dl);
+               // The Downloader will call destroy_state from it's destructor,
+               // but if we ref the Downloader, its destructor will never get 
called.
+               // No need to keep a ref, since this instance will never live 
longer
+               // than its Downloader.
+               // base_ref (dl);
        }
 
        ~PluginDownloader ()
@@ -39,7 +43,7 @@
                verb = NULL;
                g_free (uri);
                uri = NULL;
-               base_unref (dl);
+               // base_unref (dl);
                dl = NULL;
        }
 

_______________________________________________
Mono-patches maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches

Reply via email to