Author: nestor
Date: 2007-12-21 10:38:24 -0500 (Fri, 21 Dec 2007)
New Revision: 91768
Modified:
trunk/cecil/gendarme/rules/Gendarme.Rules.Smells/ChangeLog
trunk/cecil/gendarme/rules/Gendarme.Rules.Smells/ExpressionFillerVisitor.cs
Log:
2007-12-21 Nestor Salceda <[EMAIL PROTECTED]>
* ExpressionFillerVisitor.cs: Add the ceq code to the acceptable
instructions set. With this change, all the bugs in code
compiled under csc without optimization flag are fixed.
Modified: trunk/cecil/gendarme/rules/Gendarme.Rules.Smells/ChangeLog
===================================================================
--- trunk/cecil/gendarme/rules/Gendarme.Rules.Smells/ChangeLog 2007-12-21
15:35:33 UTC (rev 91767)
+++ trunk/cecil/gendarme/rules/Gendarme.Rules.Smells/ChangeLog 2007-12-21
15:38:24 UTC (rev 91768)
@@ -1,5 +1,11 @@
2007-12-21 Nestor Salceda <[EMAIL PROTECTED]>
+ * ExpressionFillerVisitor.cs: Add the ceq code to the acceptable
+ instructions set. With this change, all the bugs in code compiled under
+ csc without optimization flag are fixed.
+
+2007-12-21 Nestor Salceda <[EMAIL PROTECTED]>
+
* ExpressionFillerVisitor.cs: Avoid creating empty expressions, because
the equals method in the Expression class checks for the same size, and
if the size is zero, then the equals returns true. Fixes one of the
Modified:
trunk/cecil/gendarme/rules/Gendarme.Rules.Smells/ExpressionFillerVisitor.cs
===================================================================
--- trunk/cecil/gendarme/rules/Gendarme.Rules.Smells/ExpressionFillerVisitor.cs
2007-12-21 15:35:33 UTC (rev 91767)
+++ trunk/cecil/gendarme/rules/Gendarme.Rules.Smells/ExpressionFillerVisitor.cs
2007-12-21 15:38:24 UTC (rev 91768)
@@ -50,6 +50,7 @@
return instruction.OpCode.FlowControl ==
FlowControl.Call ||
instruction.OpCode.FlowControl ==
FlowControl.Branch ||
instruction.OpCode.FlowControl ==
FlowControl.Cond_Branch ||
+ instruction.OpCode.Code == Code.Ceq ||
instruction.OpCode.Code == Code.Stfld;
}
_______________________________________________
Mono-patches maillist - [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches