Author: nestor
Date: 2007-12-21 11:59:53 -0500 (Fri, 21 Dec 2007)
New Revision: 91773
Modified:
trunk/cecil/gendarme/rules/Gendarme.Rules.Performance/AvoidUnusedParametersRule.cs
trunk/cecil/gendarme/rules/Gendarme.Rules.Performance/ChangeLog
Log:
2007-12-21 Nestor Salceda <[EMAIL PROTECTED]>
* AvoidUnusedParameterRule.cs: If the method is anonymous then, gendarme
will skip it.
Modified:
trunk/cecil/gendarme/rules/Gendarme.Rules.Performance/AvoidUnusedParametersRule.cs
===================================================================
---
trunk/cecil/gendarme/rules/Gendarme.Rules.Performance/AvoidUnusedParametersRule.cs
2007-12-21 16:54:05 UTC (rev 91772)
+++
trunk/cecil/gendarme/rules/Gendarme.Rules.Performance/AvoidUnusedParametersRule.cs
2007-12-21 16:59:53 UTC (rev 91773)
@@ -99,11 +99,22 @@
}
return false;
}
+
+ //TODO: Is very important take a decision about the helper
+ //classes, this code is really copy pasted.
+ private bool IsCompilerGenerated (MethodDefinition method)
+ {
+ foreach (CustomAttribute custom in
method.CustomAttributes) {
+ if (custom.Constructor.DeclaringType.FullName
== "System.Runtime.CompilerServices.CompilerGeneratedAttribute")
+ return true;
+ }
+ return false;
+ }
private bool IsExaminable (MethodDefinition method)
{
return !(method.IsAbstract || method.IsVirtual ||
method.Overrides.Count != 0
- || method.PInvokeInfo != null ||
IsReferencedByDelegate (method));
+ || method.PInvokeInfo != null ||
IsReferencedByDelegate (method) || IsCompilerGenerated (method));
}
private ICollection GetUnusedParameters (MethodDefinition
method)
Modified: trunk/cecil/gendarme/rules/Gendarme.Rules.Performance/ChangeLog
===================================================================
--- trunk/cecil/gendarme/rules/Gendarme.Rules.Performance/ChangeLog
2007-12-21 16:54:05 UTC (rev 91772)
+++ trunk/cecil/gendarme/rules/Gendarme.Rules.Performance/ChangeLog
2007-12-21 16:59:53 UTC (rev 91773)
@@ -1,3 +1,8 @@
+2007-12-21 Nestor Salceda <[EMAIL PROTECTED]>
+
+ * AvoidUnusedParameterRule.cs: If the method is anonymous then, gendarme
+ will skip it.
+
2007-11-30 Sebastien Pouliot <[EMAIL PROTECTED]>
* AvoidUninstantiatedInternalClassesRule.cs: Reworked to make the
_______________________________________________
Mono-patches maillist - [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches