Author: miguel
Date: 2008-01-02 16:03:48 -0500 (Wed, 02 Jan 2008)
New Revision: 92128

Modified:
   trunk/mono-tools/gui-compare/ChangeLog
   trunk/mono-tools/gui-compare/CompareContext.cs
Log:
* CompareContext.cs: Provide some hints, not a great way of doing it.

Modified: trunk/mono-tools/gui-compare/ChangeLog
===================================================================
--- trunk/mono-tools/gui-compare/ChangeLog      2008-01-02 20:57:28 UTC (rev 
92127)
+++ trunk/mono-tools/gui-compare/ChangeLog      2008-01-02 21:03:48 UTC (rev 
92128)
@@ -1,5 +1,9 @@
 2008-01-02  Miguel de Icaza <[EMAIL PROTECTED]> 
 
+       * CompareContext.cs: Provide some hints, not a great way of doing it.
+
+2008-01-02  Miguel de Icaza <[EMAIL PROTECTED]> 
+
        
 
 2008-01-02  Chris Toshok <[EMAIL PROTECTED]> 

Modified: trunk/mono-tools/gui-compare/CompareContext.cs
===================================================================
--- trunk/mono-tools/gui-compare/CompareContext.cs      2008-01-02 20:57:28 UTC 
(rev 92127)
+++ trunk/mono-tools/gui-compare/CompareContext.cs      2008-01-02 21:03:48 UTC 
(rev 92128)
@@ -320,9 +320,16 @@
                                                if (reference_access != 
assembly_access) {
                                                        comparison.status = 
ComparisonStatus.Error;
                                                        
-                                                       // Try to give some 
hints to the developer
-                                                       comparison.messages.Add 
(String.Format ("reference access is '<i>{0}</i>', target access is 
'<i>{1}</i>'",
-                                                                               
                reference_access, assembly_access));
+                                                       // Try to give some 
hints to the developer, best we can do with
+                                                       // strings.
+                                                       string extra_msg = "";
+                                                       if 
(reference_access.IndexOf ("Public, Final, Virtual, HideBySig") != -1 &&
+                                                               
assembly_access.IndexOf ("Public, HideBySig") != -1){
+                                                               extra_msg = 
"\n\t\t<b>Hint:</b> reference uses an implicit interface implementation, target 
doesn't";
+                                                       }
+                                                               
+                                                       comparison.messages.Add 
(String.Format ("reference access is '<i>{0}</i>', target access is 
'<i>{1}</i>'{2}",
+                                                                               
                reference_access, assembly_access, extra_msg));
                                                }
                                        }
                                        

_______________________________________________
Mono-patches maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches

Reply via email to