On Tue, 2009-05-12 at 15:25 +0300, Alex Shulgin wrote: > Alex Shulgin wrote: > > Alex Shulgin wrote: > >> Sebastien Pouliot wrote: > >>> Sounds correct but will requires a lot of testing. Please open a bug > >>> report for this and copy/paste the email info into it (otherwise we'll > >>> lose track of important data). > >> > >> Thanks, filed a bug here: > >> https://bugzilla.novell.com/show_bug.cgi?id=495516 > >> > >> Will prepare a patch soon. > > > > Hi all again! > > > > I'm not posting this to the bug report, because there might be quite a > > discussion about this patch. > > I'd really, _really_ appreciate some feedback on this issue...
Thanks for your patch but *please*, like I said in my earlier email, attach all patches to the bug reports. I don't mind them being sent to any list, but not having them on the bug report means I won't see (or remember them) next time I have time to look at libgdiplus bugs. And like you've seen this is not the kind of patch to create "quite a discussion". Two things about it: 1) caution: Historically such changes requires a lot of testing outside libgdiplus. Many times it caused regressions that were found after one (or more) release(s). 2) regression: even if unit tests are not enough it still better than nothing. However when, like this patch, it breaks some* of them then it's likely to break existing apps too (which often supplied, even if indirectly, those test cases). Sebastien * it may looks strange but the number of bug reports abouts icons, and their specific behavior, is much greater than the one about transparency _______________________________________________ Mono-winforms-list maillist - Mono-winforms-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-winforms-list