I've been rethinking. Ignore that, changing the approve command will not really make things better, because then we need to check that the value of an "approved" cert matches any available "branch" cert or the current branch, and that would require something quite a bit more complex than the current get_revision_cert_trust hook.
What would be needed is perhaps have approve avoid adding a branch cert for a branch the revision isn't already in... In message <[EMAIL PROTECTED]> on Fri, 10 Feb 2006 17:25:36 +0100 (CET), Richard Levitte - VMS Whacker <[EMAIL PROTECTED]> said: levitte> Hi, levitte> levitte> I'm taking a look at the current revision approval possibilities, and levitte> there are things I don't quite understand. Also, it looks like this levitte> hasn't been looked at for ages. levitte> levitte> First of all, we probably need to rewrite the example for the levitte> get_revision_cert_trust, as it currently uses the "ancestor" cert, levitte> which hasn't existed since versoin 0.15 (when we switched to levitte> changesets). levitte> levitte> Second, the approve command adds a branch cert, and I would like for levitte> someone to explain the rationale behind that. I assume that the levitte> branch name is meant to express a little more exactly what is being levitte> approved, could that be correct? It seems to me that setting an levitte> explicit branch might even be a bit dangerous. If I decided to levitte> approve monotone with a special branch, for example levitte> net.venge.monotone.approved.linux, it would mean that we end up with a levitte> branch that seems to have multiple heads or something like that. It levitte> would be a very disconnect graph at the very least. levitte> levitte> It would be interesting to know how many are actually using these two levitte> features. Does anyone use the approve command? Does anyone use the levitte> get_revision_cert_trust hook? If there was a change in those, would levitte> anyone get hurt? levitte> levitte> I've a proposal: levitte> levitte> 1. change the approve command to add a "approved" cert rather than a levitte> "branch" one. Other than that, it works exactly the same way as levitte> before. levitte> 2. rewrite the example for the get_revision_cert_trust to look at a levitte> "approved" cert. levitte> levitte> Comments? levitte> levitte> Cheers, levitte> Richard levitte> levitte> ----- levitte> Please consider sponsoring my work on free software. levitte> See http://www.free.lp.se/sponsoring.html for details. levitte> levitte> -- levitte> Richard Levitte [EMAIL PROTECTED] levitte> OpenSSL Project http://www.openssl.org/~levitte/ levitte> levitte> levitte> _______________________________________________ levitte> Monotone-devel mailing list levitte> Monotone-devel@nongnu.org levitte> http://lists.nongnu.org/mailman/listinfo/monotone-devel _______________________________________________ Monotone-devel mailing list Monotone-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/monotone-devel