...Actually, it looks as though the mkdir and the commit_using__MTN_log tests might have broken due to the patch being applied, but add --unknown not being called?
A freshly checked out mtn doesn't include tests/mkdir/* or tests/commit.../commit_log_modified_return.lua. The patch I submitted to fix the other tests should work to correct the other tests that were failing. Thanks -Ben On 12/15/06, Nathaniel J. Smith <[EMAIL PROTECTED]> wrote:
On Mon, Dec 11, 2006 at 11:34:23AM -0500, Ben Walton wrote: > 2006-12-11 Ben Walton <[EMAIL PROTECTED]> > * cmd_ws_commit.cc, > tests/commit_using__MTN_log/commit_log_modified_return.lua, > tests/commit_using__MTN_log/__driver__.lua: > Added the requirement that when _MTN/log is pre-specified by > the user, that the user remove a 'magic' line prior to the > commit being accepted. Modified the units tests to verify this. > Updated texinfo to match this new behaviour. It looks like this broke a few tests; e.g. search for "FAIL" in http://venge.net:9000/linux_suse_9.3_x86_unopt/builds/50/test/0 They mostly look like the tests need updating, rather than that the actual code is broken. I'm not sure how annoying it will be to fix some of them; I almost wonder if the actual ******DELETE THIS LINE***** handling should move to be more of the hook's responsibility? (Like we tell the hook when we think some extra confirmation might be needed, and the hook tells us when it thinks that that extra confirmation has been given.) Just a random thought, though. -- Nathaniel
-- --------------------------------------------------------------------------------------------------------------------------- Ben Walton <[EMAIL PROTECTED]> Unanswered questions are far less dangerous than unquestioned answers. - The Roadside Pulpit --------------------------------------------------------------------------------------------------------------------------- _______________________________________________ Monotone-devel mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/monotone-devel
