On Fri, 26 Jun 2009, Hans Dieter Pearcey wrote:
The attribute_helpers branch is done and ready to merge. Can someone please
review it? (Shawn, this probably means you at least.)
Here's some initial TODOs:
* POD docs for every method provided. Some providers have docs, some
don't.
* Rename Moose::AttributeHelpers::Trait::Base to something else, it's not
a base class any more.
* POD style varies from the Moose standard. For methods, it's:
=item B<< $object->method($arg1, $arg2) >>
* Should any methods in ::Base actually be public? I suspect not.
* Add a note in the Moose::AttributeHelpers docs that this used to MX::AH?
* I just took a look at Bag for the first time, and it's not a bag, it's a
CountingHash (CounterHash, HashCounter?). A bag is a multi-set (like a
set, but allows dupes). Now is a good time to rename it.
There are also some other things I'm going to review myself now, and just
check in.
-dave
/*============================================================
http://VegGuide.org http://blog.urth.org
Your guide to all that's veg House Absolute(ly Pointless)
============================================================*/
