Anton Bobrov wrote:

1) I'm pretty sure the reference to socket should be fd instead. I don't know why it compiled with socket in there . . . note to self: read compiler warnings . . .


maybe it should be socket_fd or something ? ;)

I confirmed with Mark that it's fd.


2) The cert returned by SSL_PeerCertificate is "dup"ed, so we need to call CERT_DestroyCertificate to release it otherwise we'll leak references.
3) The hostname returned by SSL_RevealURL is strduped and must be freed.

We only found this because when we use the ldapsdk in Apache, and we unload mod_nss, NSS_Shutdown complains about non-zero ref counts . . .



looks good to me.
_______________________________________________
mozilla-directory mailing list
[email protected]
http://mail.mozilla.org/listinfo/mozilla-directory

Reply via email to