Sorry, thought of some other things...

Chris Waterson wrote:

> But, above all, FOLLOW LOCAL CONVENTION! Your job is not to proselytize
> Your Favorite Style. Your job is to make it easier on the next person
> that has to work on the mess. This applies to:


...but does _not_ apply to:

   - Use of manual refcounting. You're allowed to ``upgrade''
     crufty old COM code to use nsCOMPtr

   - C-style casts. You're allowed to ``upgrade'' a C-style
     cast to NS_STATIC_CAST or NS_REINTERPRET_CAST.

> Some other random rants.


- Code for Debugging. For example, don't place a statement
   on the same line as the |if| condition:

   wrong:

     if (!busy) GoGrabABeer();

   right:

     if (!busy)
       GoGrabABeer();

   That way, you can set a breakpoint on the line that calls
   the function.






Reply via email to