[EMAIL PROTECTED]">http://www.mozilla.org/hacking/getting-cvs-write-access.html says:[EMAIL PROTECTED]">I'm not sure where the breakdown is here. if you're checking into the tree, you're looking at tbox (WAP/vxml tbox access isn't enough), and at the top of tbox is the text:
"Checkin comment should include the reviewer (e.g. [EMAIL PROTECTED]), the super-reviewer (e.g. [EMAIL PROTECTED]), a clear explanation of the fix , and the bug number. Reviewers and approvers are considered to be 'on the hook'! "A couple comments:
Looking at the top of tinderbox, I see "All Mozilla contributors: blah blah blah blah blah. Add new files to the Mac/Win/Unix packages! Netscape employees: blah blah blah blah blah." That is, the text is there, but it's not presented in such a way that it will be read. It's very hard not to gloss over. Of course, I hardly see that as an excuse for not following the rules, but it's something to think about. I'll just say that presenting information in such a way that you're certain it's been both read, understood, and remembered, is hard.
"You'll need to demonstrate competence with the code you're working with, other Mozilla code you might affect with your work, mozilla.org check-in, build and related processes (like watching the builds when you’re on the hook) and basic good coding practices."
I don't think we can let check-in processes be defined in ether as time passes us by, and that's what I thought the top of tbox was for; black and white rules.
[EMAIL PROTECTED]">those poor souls should *not* be checking into the tree; period. they waste your time and mine. sheriffs should be backing them out if things break and they're not around to repair the damage.You're also making an assumption. It's plain to see that some poor souls aren't even looking at tinderbox when they check in, let alone waiting to see that their checkins have cleared.
[EMAIL PROTECTED]">IMO, the getting-cvs-write-access doc implies, perhaps it should be more explicit (another cvs-write-access doc revision anyone :-)) this pre-requisite knowledge.Perhaps a part of getting CVS access should be a test of the rules. The rules aren't too hard to find, but the point is that the contributor-to-be has found them at least once and is using part of their brain to process and transcribe them into the test...
Jud
