In a number of recent reviews, I've seen some common mis-uses of strings.. we've documented these before, so I just wanted to send the link around again. EVEN IF YOU THINK YOU KNOW YOUR STRINGS, please at least look over the first link - it will take you 2 minutes at the most.
The string quick-reference guide: http://www.mozilla.org/projects/xpcom/string-quickref.html Explains some common bad patterns and how we should handle them The full String Guide: http://www.mozilla.org/projects/xpcom/string-guide.html A huge brain dump of how strings work, to the best of my knowledge. I highly encourage people to peruse these documents - strings are used in every part of our code, and so every developer working on mozilla should be as familiar with them as they are with XPCOM. Alec
