> From: Sergey A. Maslyakov [mailto:[EMAIL PROTECTED]]
> Sent: Friday, September 24, 1999 6:46 AM
> To: Mathew Hendry
> Subject: Re: [MP3 ENCODER] lame 3.29
> 
> 23.09.1999 at 05:58:20 you wrote to me:
> 
> >> In my case (lame3.29/win32 compiled using guidelines by Mathew
> >> Hendry) it just crashes. However, it writes some data on disk
> >> (16'590 bytes in this case).
> MH> MSVC's open/read/close functions appear to be broken. Quick fix:
> [...]
> MH> That seems to fix it.

I'd suggest using Iwasa Kazmi's fix instead. i.e. in musicin.c

#if defined(__CYGWIN__) || defined(_MSC_VER)
    original_file_fd = open(inPath,O_RDONLY|O_BINARY);
#else
    original_file_fd = open(inPath,O_RDONLY);
#endif

(O_BINARY should perhaps be used in all cases anyway).

>   Yes, it does! Thanks!
>   The only problem that appears to be is that the progress indicators
>   become almost useless because they do not show estimated 
> "timings" of
>   the whole process.

I think that's because unlike WAV etc., there is no length information
in the MP3 header. The whole MP3 (well, the headers of all the frames)
would have to be pre-scanned to give a time estimate.

-- Mat.
--
MP3 ENCODER mailing list ( http://geek.rcc.se/mp3encoder/ )

Reply via email to