I noticed that scalefac in function lame_encode is not static, therefore it
is not initialized to zeros (can contain bugus values). However, this vakue
is used in best_scalefac_store function (with fools.wav) before scalefac is
set in the outer_loop.
Albert
----- Original Message -----
From: Robert Hegemann <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Thursday, February 10, 2000 9:27 PM
Subject: Re: [MP3 ENCODER] CVS code status
Mark Taylor schrieb am Don, 10 Feb 2000:
> Ok, I'm giving up trying to track down that floating point exception bug,
> and reverted CVS back to the original code, with the following fixes:
>
> VBR_min/max bitrate index set properly (Robert)
> s3_s spreading function bug fixed (Alfred Weyers)
> npart_l/npart_l_orig problems fixed? This was causing one of the
> floating point exceptions.
>
> Takehiro's code, which is faster and improves the logic of the
> noise & distortion calculations can be checked out with:
>
> cvs update -r takehiro2 quantize.c quantize-pvt.h loopold.c
> ("cvs update -A" to go back to main CVS version)
>
> After that scalefac indexing bug was fixed, this code now passes all
> my tests (when compiled w/o -DABORTFP), but I still get floating point
> exception errors when compiled with -DABORTFP. As soon as this
> problem is tracked down, these will be merged back into the main
> branch. So if possible, hold off on committing changes to these three
> routines. If you really want to commit some changes, track down the
> exception for me!
>
> Mark
So, do you still get floating point exception errors even without
Takehiro's improved versions of quantize.c quantize-pvt.h loopold.c?
I do. (With and without my latest changes, there is no difference)
The following command produces--sooner or later--floating point exceptions:
lame -v --preset cd Fools.wav Fools.mp3
I think Takehiro's improvements are not the reason for the trouble we are
in.
In the next few days I will try some older versions of Lame
to see if I can find the latest working version. Then we will have to
see what changes these errors cause. Or have you already done this?
If so, please tell me.
Robert
--
MP3 ENCODER mailing list ( http://geek.rcc.se/mp3encoder/ )
--
MP3 ENCODER mailing list ( http://geek.rcc.se/mp3encoder/ )
