Hi there.

thanks for mpd!

i have mpd outputing audio to jack.

audio_output {
        type        "jack"
        name      "My JACK Device"
}

and i use an alsa output just to remote control a mixer.

audio_output {
        type            "alsa"
        name            "My ALSA Mixer"
        device          "none"  # <=
        mixer_device    "hw:1"
        mixer_control   "Master"
}

this is working perfectly, as intended. however, mpd actually tries to
use alsa for output as well. and complains a lot, spamming the log file.

ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM none
Jan 23 21:31 : alsa_output: Failed to open "My ALSA Device" [alsa]: Failed to 
open ALSA device "none": No such file or directory

it would be nice to have some way to disable this. see below for the simplest 
patch i can think of.

cheers
felix

--- src/output/plugins/AlsaOutputPlugin.cxx.orig        2015-01-23 
22:33:12.504103553 +0100
+++ src/output/plugins/AlsaOutputPlugin.cxx     2015-01-23 22:33:51.020713524 
+0100
@@ -704,6 +704,10 @@ alsa_open(AudioOutput *ao, AudioFormat &
 {
        AlsaOutput *ad = (AlsaOutput *)ao;
 
+       if(!strcmp(alsa_device(ad)), "none") {
+               return false;
+       }
+
        int err = snd_pcm_open(&ad->pcm, alsa_device(ad),
                               SND_PCM_STREAM_PLAYBACK, ad->mode);
        if (err < 0) {

_______________________________________________
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Reply via email to