On 2015/05/18 23:27, Ben Boeckel <maths...@gmail.com> wrote: > I like the feature :) . Comments inline (FWIW, I am not a developer of > MPD; a user an occasional patcher).
Thanks Ben, that sounds much like what I would have replied. > > diff --git a/scripts/mpd.secret.py b/scripts/mpd.secret.py > > new file mode 100755 > > index 0000000..30cb497 > > --- /dev/null > > +++ b/scripts/mpd.secret.py > > @@ -0,0 +1,111 @@ > > +#!/usr/bin/env python3 > > This looks like a new runtime dependency; is it documented anywhere? I also wonder why there is a Python script for doing stuff. Adding such a dependency doesn't sound like a good idea at all, and doing so must be justified very well. I don't understand what this Python script is about. It's not documented, is not installed by "make install", it is not used by MPD. + // When to free? Such problems must be solved BEFORE submitting code. Max _______________________________________________ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel
