On Sunday 11 January 2009 13:22:08 Bill Hart wrote: > OK, I tried adding the prototype. I've committed that to trunk. Does > that fix it for you? >
Yes :) > Bill. > > 2009/1/11 jason <ja...@njkfrudils.plus.com>: > > trunk 1554 on linux K8 I get this warning on compilation > > > > /bin/sh ../libtool --tag=CC --mode=compile gcc -std=gnu99 - > > DHAVE_CONFIG_H -I. -I. -I.. -D__GMP_WITHIN_GMP -I.. -DOPERATION_`echo > > ngcd | sed 's/_$//'` -O2 -m64 -march=k8 -mtune=k8 -c -o ngcd.lo > > ngcd.c > > gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I. -I.. -D__GMP_WITHIN_GMP -I.. - > > DOPERATION_ngcd -O2 -m64 -march=k8 -mtune=k8 -c ngcd.c -fPIC -DPIC - > > o .libs/ngcd.o > > ngcd.c: In function 'mpn_ngcd': > > ngcd.c:75: warning: implicit declaration of function 'mpn_basic_gcd' > > gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I. -I.. -D__GMP_WITHIN_GMP -I.. - > > DOPERATION_ngcd -O2 -m64 -march=k8 -mtune=k8 -c ngcd.c -o ngcd.o >/dev/ > > null 2>&1 > > > > Otherwise great > > > > On Jan 10, 5:45 pm, "Bill Hart" <goodwillh...@googlemail.com> wrote: > >> I declared them, but not in gmp.h, so they aren't exposed to the user. > >> > >> I think you are right about much of it being trial code. We'll have to > >> clean up the detritus one day. For now it is probably ok, and > >> manifestly works. > >> > >> Bill. > >> > >> 2009/1/10 Jason Martin <jason.worth.mar...@gmail.com>: > >> > This wasn't clear to me. > >> > > >> > From the structure of the Moller LGPL v2.1 patches, it looks to me > >> > like these were "proof of concept" code. I suspect that he cleaned > >> > the code up a lot for the GMP 4.3 contribution, but I haven't looked > >> > at it because I didn't want to "taint" the v2.1 version with a > >> > possible copyright violation. I only saw the top level gcd function > >> > being exposed. However, it is very likely that I missed something > >> > (especially considering all the automagic games that get played with > >> > function names). > >> > > >> > I, personally, don't think they should be exposed because it looks > >> > like many of them are just trial code. (For example the Lehmer code > >> > looks very experimental.) > >> > > >> > We could declare them just to prevent compilation warnings. > >> > > >> > --jason > >> > > >> > On Sat, Jan 10, 2009 at 11:50 AM, Bill Hart <goodwillh...@googlemail.com> wrote: > >> >> Perhaps one only does this for functions exposed to the user via > >> >> gmp.h? > >> >> > >> >> Bill. > >> >> > >> >> 2009/1/10 Bill Hart <goodwillh...@googlemail.com>: > >> >>> In gmp-impl.h is a massive section for declarations of the Moller > >> >>> gcd functions. But I notice none of the prototypes are of the form: > >> >>> > >> >>> #define mpn_fnname __gmpn_fnname > >> >>> void mpn_fnname __GMP_PROTO ((mp_srcptr, mp_size_t, mp_size_t, > >> >>> long)) __GMP_ATTRIBUTE_PURE; > >> >>> > >> >>> Should they be? > >> >>> > >> >>> Bill. > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "mpir-devel" group. To post to this group, send email to mpir-devel@googlegroups.com To unsubscribe from this group, send email to mpir-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/mpir-devel?hl=en -~----------~----~----~----~------~----~------~--~---
