On Monday, March 31, 2014 9:28:51 PM UTC+2, Jean-Pierre Flori wrote: > > > > On Monday, March 31, 2014 9:20:51 PM UTC+2, Jean-Pierre Flori wrote: >> >> >> >> On Monday, March 31, 2014 9:15:15 PM UTC+2, Jean-Pierre Flori wrote: >>> >>> Dear all, >>> >>> I think the fix in >>> https://github.com/wbhart/mpir/commit/053476c4567874223180485ff0a4fa808d0ab4d1is >>> actually wrong. >>> What you did is basically go back to the previous state of >>> configure.in/ac with regards to AC_PROG_CXX. >>> But note that it should not be run conditionally this way, whence my >>> (not quite correct) fix. >>> In particular, running it conditionnally as it is now will completely >>> break the autotools magic if mpir is built without C++ support at least on >>> Cygwin. >>> See http://cygwin.com/ml/cygwin/2013-06/msg00580.html and >>> http://cygwin.com/ml/cygwin/2013-06/msg00620.html >>> >>> So we should come up with a better solution. >>> >>> Best, >>> JP >>> >>> Maybe move "test_CXXFLAGS=${CXXFLAGS+set}" out of the conditional >> together with and before AC_PROG_CXX. >> > This seems to work (and I also reproduced the broken CXXFLAGS treatment > when just AC_PROG_CXX was moved).. > (I mean: I tested that CXXFLAGS is now correctly treated on Linux only, though I'm quite confident it should be ok on more exotic platforms.)
-- You received this message because you are subscribed to the Google Groups "mpir-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to mpir-devel+unsubscr...@googlegroups.com. To post to this group, send email to mpir-devel@googlegroups.com. Visit this group at http://groups.google.com/group/mpir-devel. For more options, visit https://groups.google.com/d/optout.
