Hi! A few comments on this patch. The change is fine with me, these are just nitpicks (well, maybe except for the second point). - The change in conf.c does not seem necessary? - The error messages printed from expand_session_variables() should be avoided: just leave trailing '%' and unsupported expansions in the string. - The step-logic in expand_session_variables() looks unusual. The idea is to first count how much space you need, and do the actual replacement in the second step?
Regards, Martin ------------------------------------------------------------------------------ Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho _______________________________________________ mpop-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mpop-users
