I'm the author of the "Hobbit" monitoring tool, which uses RRDtool. While testing with the new RRDtool 1.2.1, I noticed that the rrd_create() routine modifies all "RRA:..." parameters passed to it. This is a change in behaviour from RRDtool 1.0.x which leaves these parameters unchanged. I believe this is a bug, since rrd_create() should not assume that these strings are at all writable.
Digging into the sources, it seems this is due to the use of strtok_r() directly on the parameters passed as input to rrd_create(). A patch to restore the behaviour from RRDtool 1.0.x is included below; this avoids modifying the input parameter by using a copy of the parameter for the strtok_r() operations. It also fixes a simple bug where strncmp() compares only the first 3 characters of the string "RRA:" with the input parameter. Regards, Henrik -- Attached file removed by Ecartis and put at URL below -- -- Type: text/plain -- Size: 1k (1399 bytes) -- URL : http://lists.ee.ethz.ch/p/rrdtool-1.2.1-rrdcreate.patch -- Unsubscribe mailto:[EMAIL PROTECTED] Help mailto:[EMAIL PROTECTED] Archive http://lists.ee.ethz.ch/rrd-developers WebAdmin http://lists.ee.ethz.ch/lsg2.cgi
