[ 
https://issues.apache.org/jira/browse/MRUNIT-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217963#comment-13217963
 ] 

Jarek Jarcec Cecho commented on MRUNIT-68:
------------------------------------------

As far as I know, code that is not explicitly allowed to be included in Apache 
works can't be just included in Apache projects. I'm personally thinking about 
it as "I can't commit this code". I do not believe that you can't even look on 
that :-)

Reason why I've submitted the patch without granting Apache license is to put 
stress that is not ready to be committed. It's just feature preview and I'm 
strongly looking for any feedback prior finishing it.

@Brock: Thanks for the support, I'll finish the patch.

Jarcec
                
> Support custom counter checking
> -------------------------------
>
>                 Key: MRUNIT-68
>                 URL: https://issues.apache.org/jira/browse/MRUNIT-68
>             Project: MRUnit
>          Issue Type: New Feature
>            Reporter: Jarek Jarcec Cecho
>         Attachments: MRUNIT-68.patch
>
>
> It would be great if user could check custom counter values in addition to 
> checking outputs. Let me show my idea on example, right now counters needs to 
> be checked explicitly:
> assertEquals(2, 
> mapDriver.getCounters().findCounter(CustomMapper.CustomCounter.NAME).getValue());
> It would be great if user could do something like:
> .withCounter(CustomMapper.CustomCounter.Name, 2)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to