[
https://issues.apache.org/jira/browse/MRUNIT-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237313#comment-13237313
]
Jim Donofrio edited comment on MRUNIT-91 at 3/23/12 11:56 PM:
--------------------------------------------------------------
I do not agree with disabling order by default, this has been the convention
that users has been used to from the beginning. They will continue to make this
assumption no matter how well this change is documented. I would make the
default to care about order and allow you to turn it off by setting a boolean
in runTest.
It would be confusing to have runTest default to ignoring order for mappers and
caring about order in the rest of the api
was (Author: jdonofrio):
I do not agree with disabling order by default, this has been the
convention that users has been used to from the beginning. They will continue
to make this assumption no matter how well this change is documented. I would
make the default to care about order and allow you to turn it off by setting a
boolean in runTest
> runTest() should optionally ignore output order
> -----------------------------------------------
>
> Key: MRUNIT-91
> URL: https://issues.apache.org/jira/browse/MRUNIT-91
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 0.8.1
> Reporter: William McNeill
> Priority: Minor
> Labels: order
>
> Currently MapDriver.runTest() assumes that the order of pairs emitted by the
> mapper matches the order of the MapDriver.addOutput() calls. However, there
> are valid mappers that for a given input pair produce output pairs whose
> order is unspecified for testing purposes. (For example, if the mapper being
> tested uses a set object for deduplication before emission.) runTest() cannot
> be used to test these kinds of mappers.
> A workaround is to not use runTest() but instead put the output of run() into
> a Set and assert that the contents of the set are correct, bypassing MRUnit's
> validation code.
> A possible improvement would be to add a boolean orderMatters parameter to
> MapDriver.runTest(), invoking an order-insensitive version of
> TestDriver.validate() when orderMatters is false and the existing version
> otherwise.
> For clarity's sake only mappers are discussed in this feature request, but
> the same applies to reducers as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
