I did find the rest of the history on sourceforge. I was making the mistake at looking at the 1.3 tag, not seeing that there was a "trunk" totally separate from the list of tags. So now I can see *when* the code I was wondering about got changed, even if it is not clear *why*. I guess I shouldn't worry about it, but I do tend to wonder when code is merely commented out rather than rewritten or deleted. See below
But first, an aside for lasconic and Werner. I'm still wanting to take my time about this final stage. If you're thinking you should hold up on my pull request for the previous stage until I implement import/export for unrecognized chords, I'd say don't. I'm now working on a separate branch and have no plans to touch the code on the branch I already submitted the pull request for. The code I've already committed should stand on its own. But do let me know if you have any concerns or questions I can answer. As you know, I'm only too happy to explain :-) For Leon (and Werner): For HDegree::Text(), the change to effectively no-op it was part of this revision from Werner last March: http://sourceforge.net/p/mscore/code/5443/ The main thrust of this revision seems to be unrelated - something about manual offsets for chords imported from older versions of MuseScore. No other code that relates to HDegree:text() or any other aspect of MusicXML import/export seems to have been touched, so it's kind of mysterious. I guess since things do work as they are, I am not going to dwell on this further unless Werner wants to shed some light on it. I see where I need to tie in to handle an imported chord not recognized from the chord id list, and I can make it work even if HDegree:text() eventually reverts back to its former (working?) state. As for the "#if 0" code in exportxml.cpp, that goes back quite a bit farther. It looks like the initial code for harmony export showed up in a very different form in early 2008 courtesy of Werner: http://sourceforge.net/p/mscore/code/687/ The code that is currently #ifdef'ed out was added about a month later - as active code - by Leon: http://sourceforge.net/p/mscore/code/811/ This was then #ifdef'ed out and replaced with the current code by Werner another month later: http://sourceforge.net/p/mscore/code/902/ So we're talking about code that was in place for about one month over five years ago. I think I can stop hoping to hear a useful explanation of why it was replaced, and more importantly, I can probably stop wondering if this code is going to be re-enabled any time soon :-) Anyhow, the code relating to MusicXML and the internal representation of chords with HChord's and HDegree lists and so forth seems more delicate and less self-contained than what I have been working on thus far. So I am treading carefully, working on understanding things before hacking away. I still don't think the actual changes themselves will be very involved, but I want to get it right so I don't break anything. Marc ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d _______________________________________________ Mscore-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mscore-developer
