As stated on IRC 1/ I believe the switch from Element::ElementType to ElementType was requested for cosmetic reason only. So there should be no harm in rolling it back.
2/ The typographic simplification is fine and will balance a (very little) bit the previous loss. We just need to make sure we are not colliding with Windows header like recently with NO_ERROR. lasconic 2014-06-24 19:02 GMT+02:00 Maurizio M. Gavioli <miwa...@miwarre.org>: > Jojo-Schmitz wrote >> Agreed for ElementType, could be Element::Type, just 2 characters more to >> type, outside of Element >> And ElementFlag to Element::Flag (although not used as Q_ENUMS(), or >> should we just ignore those?) >> And DynamicRange could be turned into Dynamic::Range. >> And Placement to Element::Placement > > Yes, this makes sense. However, I would like to see comments on this topic > from Nicolas or Werner: ElementType was Element::Type until a few weeks ago > when Werner took the enum out of the Element class; I assume there was a > reason for this, so it is better to know if we are breaking something (and > what), if we go backward. > > About ElementFlag: the reason for this change is to make the enum's > available to the plug-in framework; something which is not an enum or which > is not planned to be available to the plug-in framework does not need to be > changed (unless there are other reasons for this, of course). > > >> (and Accidental::AccidentalType to Accidental::Type, >> Accidental::AccidentalRole to Accidental::Role, Dynamic::DynamicType into >> Dynamic::Type (although not used as Q_ENUMS()), Hairpin::HairpinType to >> Hairpin::Type, LayoutBreak::LayoutBreakType to LayoutBreak::Type, >> Trill::TrillType to Trill::Type, did I miss some?) > > All of this *need* not to be changed; as they already belong to a class > derived from QObject, I assume they do work in plug-ins (I cannot easily > test this right now, as plug-ins cannot access elements types). They *might* > be changed, if agreed on the typographic simplification. Again, a comment > from Nicolas or Werner would help. > > Thanks, > > Maurizio > > > > -- > View this message in context: > http://dev-list.musescore.org/Enum-s-and-plug-ins-tp7578860p7578866.html > Sent from the MuseScore Developer mailing list archive at Nabble.com. > > ------------------------------------------------------------------------------ > Open source business process management suite built on Java and Eclipse > Turn processes into business applications with Bonita BPM Community Edition > Quickly connect people, data, and systems into organized workflows > Winner of BOSSIE, CODIE, OW2 and Gartner awards > http://p.sf.net/sfu/Bonitasoft > _______________________________________________ > Mscore-developer mailing list > Mscore-developer@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mscore-developer ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ Mscore-developer mailing list Mscore-developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mscore-developer
