Great to hear about your progress !
About your question. It's mainly a question of confidence and test
coverage. If when you are ready to merge, or after 2.0 is released, you are
confident that the pull parser is close to on par with the DOM one, then I
would merge the pull parser only. If not, I would merge both with the
compile time switch. Up to you to find the sweet spot between the burden on
maintaining two parsers and the burden of keeping up to date with the
changes in core. I hope it answers your question.
lasconic
2015-03-10 22:51 GMT+01:00 Leon Vinken <[email protected]>:
> Quick status update:
>
> I am making reasonable progress and think the main / most difficult parts
> are done. The new pull parser now contains about 6400 lines of code
> compared
> to the DOM parsers 7200 lines. About half the auto testers test cases pass
> (46 out of 95).
>
> Given the amount of work remaining and the time left, I do not expect to be
> able to finish the pull parser before March 24th. Current plan is to focus
> on finishing the "most used" features and postpone some low risk "less
> used"
> features such as harmonies and tablature. I think these can safely be added
> later.
>
> Nevertheless, I still think it is necessary to merge the status as is
> immediately after release of 2.0. The simple reason being that once major
> changes are made to the core, I will never be able to keep up and basically
> all the effort spent on the pull parser will be wasted. As this currently
> amounts to about two full weeks of effort, I would be highly disappointed
> if
> that would happen.
>
> A question to the core developers about strategy: in my branch the pull
> parser is a compile time switch. Options are to leave the switch in (both
> the DOM and pull parser source code are in the release, more migration
> effort for core changes, easy fallback in case the pull parser fails) or to
> simply remove the switch and the DOM parser, leaving only the pull parser.
> I
> can easily do both, what would your preference be ?
>
> Regards, Leon.
>
>
>
> --
> View this message in context:
> http://dev-list.musescore.org/Migrating-MusicXML-import-to-pull-parser-tp7579106p7579132.html
> Sent from the MuseScore Developer mailing list archive at Nabble.com.
>
>
> ------------------------------------------------------------------------------
> Dive into the World of Parallel Programming The Go Parallel Website,
> sponsored
> by Intel and developed in partnership with Slashdot Media, is your hub for
> all
> things parallel software development, from weekly thought leadership blogs
> to
> news, videos, case studies, tutorials and more. Take a look and join the
> conversation now. http://goparallel.sourceforge.net/
> _______________________________________________
> Mscore-developer mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mscore-developer
>
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Mscore-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
