A few remarks:
- the return is intended and correct: if ml is empty, the remainder of the
function cannot (and should not) be executed.
- the test is obviously a typo, thanks for catching that, it was meant to be
"if (!(ms.size() > 0))" (note extra pair of parentheses)
- due to a few lucky coincidences, the code as is ("if (!ms.size() > 0)")
executes correctly (size = 0 is interpreted as false, !false evaluates to
"1" in an integer context, note ! has precedence over >)
- "if (ms.isEmpty())" would be the most concise rewrite
- my Xcode version (4.6.3) does not warn me for this error, otherwise I
would have fixed it
- I would very much like MuseScore to compile without warnings on Xcode,
simply because the current amount of warnings easily mask serious problems,
but this seems a lot of work. If clang is more strict than gcc (used by
Werner), Xcode warnings will keep creeping in :-(.
--
View this message in context:
http://dev-list.musescore.org/review-of-compiler-warnings-tp7579292p7579294.html
Sent from the MuseScore Developer mailing list archive at Nabble.com.
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Mscore-developer mailing list
Mscore-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mscore-developer
