>> On the other hand, if it does work, that means the code to do what I want is basically already there. I would just have to add a "button" which would effectively: play from end as if there were a DC there.
I've been recently working on RepeatList::unwind(), which is where all the implementation for skipping all but last ending would likely go, so I'd advise you stay out of there for now, since I have a pull request just submitted which changes that function, and I will be likely to be doing some more changes around that, especially considering I've just self-assigned myself the feature request "Add a property "with repeats" to jumps (like D.S. al Coda)" (https://musescore.org/en/node/56451) which Jojo had initially started. Unfortunately my latest pull request will unwind section by section individually (https://github.com/musescore/MuseScore/pull/2172) which means that the trick of putting a DC at end will only work for the current section you put the DC on. I think it would be better if you make a feature-request on the musescore issue tracker, for others to comment, as I think feature requests belong there, not on this mailing list. Maybe if you already have a mockup of the button ready you could post a screenshot with the feature request. Considering that the button "play repeats" is currently binary ("with repeats" or "ignore repeats and play through every measure"), then I'm curious how you think a separate button would work to select the now 3 different ways to playback. (To me it should be a three-way toggle of sorts...maybe with a different icon for each mode). Anway, since I'm going to be modifying unwind some more, I could keep in mind how to make it work with a "takeFinalEndingsOnly" boolean argument. I could simply modify the condition if (isGoto && (flags & Repeat::END)) into if ((takeFinalEndingsOnly || isGoto) && (flags & Repeat::END)) and addition to maybe a few other changes. But I must warn you to not look at unwind, because it is very convoluted, and I would personally like to clean it up by making it simpler, but I believe it is the way it is as a result of the many corner cases people have discovered over the years. -- View this message in context: http://dev-list.musescore.org/skip-1st-ending-tp7579482p7579496.html Sent from the MuseScore Developer mailing list archive at Nabble.com. ------------------------------------------------------------------------------ _______________________________________________ Mscore-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mscore-developer
