On Sat, Oct 01, 2011 at 01:25:26AM -0700, Eric Decker wrote: > Hey Jasper, > > Thanks for the find. > > Here is the situation.... > > First, these files come directly from TI and for maintanence and sanity > reasons we don't want to modify them. There is a very simple mod done at > the very front which adds the define for TI_HEADERS. Peter takes care of > that. And he may very well push your find back to TI so they can correct > the mistake. > > But... Those comments mostly are useless. Here is why.... > > The form TASSEL<n> is used by TI to denote a bit position in a field. And > the comment doesn't really add any real information. Yes it is incorrect > but in practice no one will really reference that comment anyway. > > TASSEL is a field made up of two bits that controls the select for the clock > source driving the TA clock circuit. A little bit lower in the file you > will see something like TASSEL_0. This is the define that gets used to > set the 2 bit field to the value 0, which for the 5438a means clock the TA > block from TAxCLK (the external clock input). In practice, TASSEL0/1 only > get used to build a mask and we don't really care about the comment. > > So in other words it most likely is a who cares. But if Peter cares enough > he may kick it back to TI where they may fix the comment. Doing it locally > doesn't really buy us anything and adds to the workload when a new version > of the headers gets kicked out. We want to minimize that workload. > > > hope that explains what is going on. Of course all of this is really up to > Peter. He be the Czar in Charge (CIC) :-) > > -c Hi,
Thanks for taking the time to explain this all for such a trivial find :-) I agree it's really a 'who-cares-matter', though it would be nice if TI could fix this trivial, yet incorrect comment. Cheers, Jasper > On Sat, Oct 1, 2011 at 1:09 AM, Jasper Lievisse Adriaanse > <jas...@humppa.nl>wrote: > > > Hi, > > > > it seems the comment in all the msp430mcu header files for TASSEL0 and > > TASSEL1 > > are swapped: > > > > #define TASSEL1 (0x0200) /* Timer A clock source select 0 */ > > #define TASSEL0 (0x0100) /* Timer A clock source select 1 */ > > > > though they should read: > > > > #define TASSEL1 (0x0200) /* Timer A clock source select 1 */ > > #define TASSEL0 (0x0100) /* Timer A clock source select 0 */ > > > > If that's right, two simple regexes would resolve this. Could someone apply > > this to the repo please? > > > > -- > > Cheers, > > Jasper > > > > "Capable, generous men do not create victims, they nurture them." > > > > > > ------------------------------------------------------------------------------ > > All of the data generated in your IT infrastructure is seriously valuable. > > Why? It contains a definitive record of application performance, security > > threats, fraudulent activity, and more. Splunk takes this data and makes > > sense of it. IT sense. And common sense. > > http://p.sf.net/sfu/splunk-d2dcopy2 > > _______________________________________________ > > Mspgcc-users mailing list > > Mspgcc-users@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/mspgcc-users > > > > > > -- > Eric B. Decker > Senior (over 50 :-) Researcher -- Cheers, Jasper "Capable, generous men do not create victims, they nurture them." ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2dcopy2 _______________________________________________ Mspgcc-users mailing list Mspgcc-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mspgcc-users
