On Dec 16, 2007, at 7:47 PM, Johannes Sixt wrote:
On Sunday 16 December 2007 07:55, Johannes Schindelin wrote:
Hi,
On Sat, 8 Dec 2007, Johannes Sixt wrote:
On Saturday 08 December 2007 16:05, Steffen Prohaska wrote:
I merged mingw/master (bd8d78a1) and pushed the result to
work/merge-mingw (a1e84247) in 4msysgit.
I disabled testing of git commit --interactive because we do not
yet
support Git.pm.
t7502-commit.sh freezes on "git status -v". I suspect this is
related
to the "dup-dance" in wt_status_print_verbose(). But I'm not
sure and
have no further idea how to fix this. When I run "git status -v"
from
the command line it works. But if it is run from the test script it
freezes.
When I run git-status in the debugger, it freezes, too. It
happens at
the first printf() after the dup-dance. I don't remember the exact
function, though. So, your suspicion is correct, but I don't have a
solution, either.
This works, but don't ask me why:
- if (saved_stdout < 0 ||dup2(fileno(s->fp), STDOUT_FILENO) < 0)
+ if (saved_stdout < 0 || dup2(dup(fileno(s->fp)), STDOUT_FILENO)
< 0)
I carry around this one:
http://repo.or.cz/w/git/mingw/j6t.git?
a=commitdiff;h=3805d587572fd50b2e8bb6af6b1dbccffb6807e5
since a few days on my other computer, but I forgot to include it in
mingw.git.
I think this is the preferable solution. Avoiding the dup-dance
instead of adding another dup seems to be saner until we can
avoid the dance altogether.
Will you take the commit on mingw's master?
Steffen
