I like to write batch scripts to execute several git commands at the same time. Now the @echo off (in the first line of the git.cmd) disables echo, so that I am not able to see which command are executing (except for the very first one :-)
With other words, now the git.cmd batch performs two distinct tasks: - execute git.exe in the proper way - disables echo (while ideally it should preserve the echo state that was before git.cmd execution) The last task does not look to be natural for the git.cmd at all. I don't know how to preserve the original echo state (after git.cmd execution), but if git.cmd switch off echo at the start, it should switch it on back at the end. It is just my personal meaning of course, and nothing more. > Also, please follow /git/Documentation/SubmittingPatches. Will see at this. On Mon, Jun 23, 2008 at 1:31 PM, Johannes Schindelin < [EMAIL PROTECTED]> wrote: > Hi, > > On Mon, 23 Jun 2008, Roman Terekhov wrote: > > > It could be good to insert: @echo on at the end of the git.cmd file. > > This will make the git.cmd transparent when it is used in batch scripts. > > Can you defend why it would be an appropriate change? AFAICT this would > undo a @echo off in a calling batch script. > > Also, please follow /git/Documentation/SubmittingPatches. > > Ciao, > Dscho > -- Roman Terekhov
