Finally done -- sorry for the delay! On Apr 10, 2013, at 11:18 AM, Thomas Naughton <naught...@ornl.gov> wrote:
> Hi Jeff, > > Do you know if the 'email_detailed_report_onfail' request for MTT ever got > a green light? I just checked and didn't see it in trunk. > > Quick refresher summary: > + Adds new 'email_detailed_report_onfail' flag to TextReporter > that only sends detailed report if the test was not "success". > (Similar to existing 'email_detailed_report' flag.) > > Thanks, > --tjn > > _________________________________________________________________________ > Thomas Naughton naught...@ornl.gov > Research Associate (865) 576-4184 > > > On Thu, 28 Mar 2013, Thomas Naughton wrote: > >> Hi Jeff, >> >>> Sorry for the delay in replying to this; somehow this mail slipped by me. >> >> No problem-o. :-) >> >> Yes, I just updated local checkout and appears to be just fine >> with latest trunk. >> >> Thanks, >> --tjn >> >> _________________________________________________________________________ >> Thomas Naughton naught...@ornl.gov >> Research Associate (865) 576-4184 >> >> >> On Thu, 28 Mar 2013, Jeff Squyres (jsquyres) wrote: >> >>> Sorry for the delay in replying to this; somehow this mail slipped by me. >>> >>> I'm all for what you described. Does your patch still apply to the current >>> trunk? (Texteeporter was just recently split up a bit) >>> >>> Sent from my phone. No type good. >>> >>> On Feb 28, 2013, at 10:07 PM, "Thomas Naughton" <naught...@ornl.gov> wrote: >>> >>>> Hey, >>>> >>>> First, thank you for MTT! >>>> >>>> I was curious if you would be willing to add a basic feature related to >>>> detailed emails. Basically, we only want the detailed test results if >>>> something fails. >>>> >>>> Initially I thought I could use an &if() funclet on the >>>> 'email_detailed_report' field, but it turns out the summary value used for >>>> "$overall_mtt_status" generated inside the TextFile reporter. >>>> >>>> So my solution is to just add another field for this case: >>>> >>>> # If true (1), send the detailed report if there were failures >>>> email_detailed_report_onfail >>>> >>>> Attached is a small patch against mtt-trunk (r1590). >>>> >>>> Thanks, >>>> --tjn >>>> >>>> _________________________________________________________________________ >>>> Thomas Naughton naught...@ornl.gov >>>> Research Associate (865) 576-4184 >>>> <email-detailed-report-onfail.patch> >>> >> -- Jeff Squyres jsquy...@cisco.com For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
