Hello Ilkka

On 20.11.08, you wrote:

> 
>> OS4 MUI seem always put args on stack, so here is code optimal. 
> 
> Mmmh... put args on the stack where? In hooks arguments are not passed in 
> the stack but in registers. Please take a look into SystemV ABI.

I see here that OS4 use no register to variable code and no hook entry func
as MOS and 68k need.

#else /* !__MORPHOS__ */
  #define MakeHook(hookname, funcname) struct Hook hookname = {{NULL, NULL},
\
    (HOOKFUNC)funcname, NULL, NULL}

So my guess DoMethod DoSupermethod put too vars on stack on OS4.
But this is for 68k not possible, because DoMethod is inline and no OS
Function that can change later, and there are lots of classes here without
source and of course MUI cant rebuild to use new DoMethod funcs, to
replace. 
 
> 
>> Please take a look at this code and let me know what you think about it.
> 
> This
> 
> #elif __mc68000__
> 
> does not look good. Is there better?

I dont know better maybe you ?
This define is always set on 68k compiler and SDI( and gcc(see file
gcc/longlong.h) i see use it to detect big or little endian. 

and here in SDL Code

"""""""""""""""
#define SDL_LIL_ENDIAN  1234
#define SDL_BIG_ENDIAN  4321

#ifndef SDL_BYTEORDER   /* Not defined in SDL_config.h? */
#if defined(__hppa__) || \
    defined(__m68k__) || defined(__mc68000__) || defined(_M_M68K) || \
    (defined(__MIPS__) && defined(__MISPEB__)) || \
    defined(__ppc__) || defined(__POWERPC__) || defined(_M_PPC) || \
    defined(__sparc__) 
"""""""""""""

here is code of GCC extendet define for target amigaos.I dont know if MOS or
OS4 use such defines.I can also add a new define to detect AOS68k better if
somebody like. 

builtin_define_std ("amiga");                   \
      builtin_define_std ("amigaos");                   \
      builtin_define_std ("AMIGA");                 \
      builtin_define_std ("MCH_AMIGA");                 \


> 
> 
>  Ilkka
> 
Regards


------------------------------------

Visit http://www.amiga.dk/tumult for MUI-related
information, especially about MUI custom classes.Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/MUI/

<*> Your email settings:
    Individual Email | Traditional

<*> To change settings online go to:
    http://groups.yahoo.com/group/MUI/join
    (Yahoo! ID required)

<*> To change settings via email:
    mailto:[EMAIL PROTECTED] 
    mailto:[EMAIL PROTECTED]

<*> To unsubscribe from this group, send an email to:
    [EMAIL PROTECTED]

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/

Reply via email to