SimpleMetric implementation for IntervalMetric improperly validates null check 
on duration string
-------------------------------------------------------------------------------------------------

                 Key: MUSE-204
                 URL: https://issues.apache.org/jira/browse/MUSE-204
             Project: Muse
          Issue Type: Bug
          Components: WSDM MUWS Metrics
    Affects Versions: 2.1.0
         Environment: All
            Reporter: Joel Hawkins
         Assigned To: Joel Hawkins
             Fix For: 2.2.0


        //
        // sanity check: if it's an Interval, it needs... an interval!
        //
        if (isInterval() != (getIntervalString() != null))
        {
            Object[] filler = { name };
            throw new RuntimeException(_MESSAGES.get("InvalidIntervalDef", 
filler));
        }

should be

        //
        // sanity check: if it's an Interval, it needs... an interval!
        //
        if (isInterval() && (getIntervalString() == null))
        {
            Object[] filler = { name };
            throw new RuntimeException(_MESSAGES.get("InvalidIntervalDef", 
filler));
        }


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to