Hi Vinh,

The current situation _is_ that a colon is appended to the namespace even if
the prefix is an empty string, resulting in an invalid namespace (e.g.
"xmlns:") which can't be read by parsers.
I suggested to fix the condition to test for empty strings in addition to
null prefixes.

Eitan.





Vinh Nguyen (vinguye2) wrote:
> 
> Hi Eitan,
> 
> The prefix cannot be null, so an empty string is used to indicate "no
> prefix".  It doesn't make sense to prepend a colon to the namespace if
> there is no prefix.
> 
> Otherwise, schema parsers may throw errors that a colon is found but no
> prefix is set, because they don't know the intent of why the colon was
> specified (i.e. is the prefix missing, or should it be empty string?).
> 
> -Vinh
> 
> 
> -----Original Message-----
> From: Eitan Plotnik (JIRA) [mailto:[EMAIL PROTECTED] 
> Sent: Thursday, June 26, 2008 1:39 AM
> To: [email protected]
> Subject: [jira] Created: (MUSE-290) Issue in
> XmlUtils.setNamespaceAttribute() method
> 
> Issue in XmlUtils.setNamespaceAttribute() method
> ------------------------------------------------
> 
>                  Key: MUSE-290
>                  URL: https://issues.apache.org/jira/browse/MUSE-290
>              Project: Muse
>           Issue Type: Bug
>           Components: Utilities - General, QName, and XML
>     Affects Versions: 2.2.0
>          Environment: any
>             Reporter: Eitan Plotnik
>             Assignee: Dan Jemiolo
>             Priority: Minor
> 
> 
> The method appends a colon and prefix values to the namespace if the
> specified prefix isn't null.
> It should do the same if the specified prefix is an empty string.
> E.g. modify line 1854 from "if (prefix != null)" to "if (prefix != null
> && !"".equals(prefix))"
> 
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 
> 

-- 
View this message in context: 
http://www.nabble.com/-jira--Created%3A-%28MUSE-290%29-Issue-in-XmlUtils.setNamespaceAttribute%28%29-method-tp18129230p18380798.html
Sent from the Muse - Dev mailing list archive at Nabble.com.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to