Hi, this patch set contains some more code cleanup, fixes some warnings and optimizes the audio_format struct. In addition to these 8 patches, I have imported 5 patches from Eric's branch. Have fun.
Max Eric Wong (5): build: enable -Wcast-qual -Wwrite-strings CFLAGS tag: introduce handy items_size() function tag: lock all accesses to tag_pool tag: oops, of course items is now ** and not * audio_format: volatile removal Max Kellermann (8): fix -Wcast-qual -Wwrite-strings warnings command: don't pass permission as pointer where appropriate client: added client_[gs]et_permission() command: use client_[gs]et_permission() playlist: replaced song_id_exists() with song_id_to_position() playlist: return -1 after assert(0) audio_format: converted typedef AudioFormat to struct audio_format pack the struct audio_format bs/config.mk.default | 3 configure.ac | 2 src/audio.c | 25 ++--- src/audio.h | 16 +-- src/audioOutput.c | 8 - src/audioOutput.h | 8 - src/audioOutputs/audioOutput_alsa.c | 2 src/audioOutputs/audioOutput_jack.c | 21 ++-- src/audioOutputs/audioOutput_oss.c | 2 src/audioOutputs/audioOutput_pulse.c | 2 src/audioOutputs/audioOutput_shout.c | 4 src/audio_format.h | 14 +- src/client.c | 14 ++ src/client.h | 4 src/command.c | 170 ++++++++++++++++++----------------- src/command.h | 5 - src/crossfade.c | 4 src/crossfade.h | 7 - src/decoder_api.c | 2 src/decoder_api.h | 3 src/decoder_control.h | 2 src/inputPlugins/_flac_common.h | 2 src/inputPlugins/aac_plugin.c | 4 src/inputPlugins/audiofile_plugin.c | 2 src/inputPlugins/mod_plugin.c | 19 ++- src/inputPlugins/mp3_plugin.c | 4 src/inputPlugins/mp4_plugin.c | 2 src/inputPlugins/mpc_plugin.c | 2 src/inputPlugins/oggvorbis_plugin.c | 2 src/inputPlugins/wavpack_plugin.c | 14 +- src/list.c | 9 - src/normalize.c | 4 src/normalize.h | 5 - src/outputBuffer.h | 2 src/pcm_utils.c | 36 ++++--- src/pcm_utils.h | 16 +-- src/player_thread.c | 2 src/playlist.c | 45 +++++---- src/replayGain.c | 4 src/replayGain.h | 6 - src/tag.c | 39 ++++---- src/tag_pool.c | 2 src/tag_pool.h | 3 src/timer.c | 3 src/timer.h | 5 - 45 files changed, 309 insertions(+), 241 deletions(-) ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team