Hi Max,
I've tested this recent change in archive API and it looks great. Its good
that you get the code into right shape.
- You know that the issue with tags, this ain't gonna happen in near
feature.
- The time stamp on archives: this will need to implement timestamps on
directories (all or only archives)
Should be not hard, haven't had time to look for this yet
- this crash looks like it refers to broken decoder not the archive api
thing, i've tryed hard to reproduce,
but it never happened to me
I'm not sure why this will block regular release, in general it works, and
we can leave it as disabled feature so
nobody will notice there is some partly implemented archive support at all.
I'll try to focus on the timestamp code for now
Viliam
On Mon, Feb 2, 2009 at 9:30 AM, Max Kellermann <m...@duempel.org> wrote:
> Hello Viliam,
>
> please have a look at my changes to the archive API, commit 82cfce76.
> Before you wrote the input_archive.c code, I asked you not to add
> archive specific stuff to the input_stream struct, which you did
> nonetheless. I removed it now:
>
> 7 files changed, 37 insertions(+), 135 deletions(-)
>
> The code has become smaller and simpler, and there is no archive
> specific stuff in the generic input stream library anymore. I applied
> similar tweaks to the mixer API.
>
> There are still open issues with the archive API:
>
> - no tag support
>
> - time stamp on archives is ignored, every song is always updated,
> which delays MPD update by orders of magnitudes:
> http://musicpd.org/mantis/view.php?id=1932
>
> - crash when using archives:
> http://musicpd.org/mantis/view.php?id=1972
>
> Please tell me when you are going to fix these problems. We cannot
> release 0.15 with these still open.
>
> Max
>
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
