On 2009/08/07 22:19, Tony Miller <mcfiredr...@gmail.com> wrote:
> The author has replied to me in this thread:
> http://hivelytracker.com/forum.php?action=viewthread&id=153
>
> He simply says "Credit is fine".
>
> Apparently the issue has come up before in this thread:
> http://hivelytracker.com/forum.php?action=viewthread&id=114
>
> In this thread the author states "The freely available replay code is public
> domain." The replay code is what I used.
Thanks for checking, sounds good. This means we can merge your patch.
However, I see compiler warnings & errors, see attached log file.
Could you fix all of those, please?
Max
make all-am
make[1]: Entering directory `/home/max/git/mpd'
gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I./src -pthread -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include
-DSYSTEM_CONFIG_FILE_LOCATION='"/usr/local/stow/mpd/etc/mpd.conf"'
-I/usr/include/ -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-I/usr/include -I/usr/include/libmodplug -I/usr/include/ffmpeg
-I/usr/local/stow/libcue/include/libcue-0.0
-I/usr/local/stow/libcue/lib/libcue-0.0/include -I/usr/local/stow/mpd/include
-I/usr/include/alsa -D_REENTRANT -pthread -I/usr/include/ffmpeg
-Wall -Wextra -Wno-deprecated-declarations -Wmissing-prototypes
-Wdeclaration-after-statement -Wshadow -Wpointer-arith -Wstrict-prototypes
-Wcast-qual -Wwrite-strings -pedantic -D_REENTRANT -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -O0 -ggdb -MT src_mpd-hvl_replay.o -MD -MP -MF
.deps/src_mpd-hvl_replay.Tpo -c -o src_mpd-hvl_replay.o `test -f
'src/decoder/hvl_replay.c' || echo './'`src/decoder/hvl_replay.c
src/decoder/hvl_replay.c:70: warning: no previous prototype for
'hvl_GenPanningTables'
src/decoder/hvl_replay.c:91: warning: no previous prototype for
'hvl_GenSawtooth'
src/decoder/hvl_replay.c:103: warning: no previous prototype for
'hvl_GenTriangle'
src/decoder/hvl_replay.c: In function 'hvl_GenTriangle':
src/decoder/hvl_replay.c:116: warning: comparison between signed and unsigned
src/decoder/hvl_replay.c:126: warning: comparison between signed and unsigned
src/decoder/hvl_replay.c:134: warning: comparison between signed and unsigned
src/decoder/hvl_replay.c:140: warning: overflow in implicit constant conversion
src/decoder/hvl_replay.c: At top level:
src/decoder/hvl_replay.c:148: warning: no previous prototype for 'hvl_GenSquare'
src/decoder/hvl_replay.c: In function 'hvl_GenSquare':
src/decoder/hvl_replay.c:155: warning: overflow in implicit constant conversion
src/decoder/hvl_replay.c: At top level:
src/decoder/hvl_replay.c:170: warning: no previous prototype for
'hvl_GenFilterWaves'
src/decoder/hvl_replay.c:221: warning: no previous prototype for
'hvl_GenWhiteNoise'
src/decoder/hvl_replay.c: In function 'hvl_GenWhiteNoise':
src/decoder/hvl_replay.c:235: warning: overflow in implicit constant conversion
src/decoder/hvl_replay.c: At top level:
src/decoder/hvl_replay.c:256: warning: no previous prototype for
'hvl_reset_some_stuff'
src/decoder/hvl_replay.c:365: warning: no previous prototype for 'hvl_load_ahx'
src/decoder/hvl_replay.c: In function 'hvl_load_ahx':
src/decoder/hvl_replay.c:449: warning: passing argument 1 of 'strncpy' discards
qualifiers from pointer target type
src/decoder/hvl_replay.c:507: warning: passing argument 1 of 'strncpy' discards
qualifiers from pointer target type
src/decoder/hvl_replay.c:510: error: assignment of read-only location
'(ht->ht_Instruments + (long unsigned int)((long unsigned int)i *
176ul))->ins_Name[0]'
src/decoder/hvl_replay.c:542: warning: comparison between signed and unsigned
src/decoder/hvl_replay.c: In function 'hvl_LoadTune':
src/decoder/hvl_replay.c:717: warning: passing argument 1 of 'strncpy' discards
qualifiers from pointer target type
src/decoder/hvl_replay.c:786: warning: passing argument 1 of 'strncpy' discards
qualifiers from pointer target type
src/decoder/hvl_replay.c:789: error: assignment of read-only location
'(ht->ht_Instruments + (long unsigned int)((long unsigned int)i *
176ul))->ins_Name[0]'
src/decoder/hvl_replay.c:821: warning: comparison between signed and unsigned
src/decoder/hvl_replay.c: At top level:
src/decoder/hvl_replay.c:845: warning: no previous prototype for
'hvl_process_stepfx_1'
src/decoder/hvl_replay.c:911: warning: no previous prototype for
'hvl_process_stepfx_2'
src/decoder/hvl_replay.c:911: warning: unused parameter 'ht'
src/decoder/hvl_replay.c:944: warning: no previous prototype for
'hvl_process_stepfx_3'
src/decoder/hvl_replay.c:1038: warning: no previous prototype for
'hvl_process_step'
src/decoder/hvl_replay.c:1205: warning: no previous prototype for
'hvl_plist_command_parse'
src/decoder/hvl_replay.c:1205: warning: unused parameter 'ht'
src/decoder/hvl_replay.c:1349: warning: no previous prototype for
'hvl_process_frame'
src/decoder/hvl_replay.c: In function 'hvl_process_frame':
src/decoder/hvl_replay.c:1654: warning: comparison between signed and unsigned
src/decoder/hvl_replay.c: At top level:
src/decoder/hvl_replay.c:1774: warning: no previous prototype for
'hvl_set_audio'
src/decoder/hvl_replay.c:1854: warning: no previous prototype for 'hvl_play_irq'
src/decoder/hvl_replay.c:1918: warning: no previous prototype for 'hvl_mixchunk'
make[1]: *** [src_mpd-hvl_replay.o] Error 1
make[1]: Leaving directory `/home/max/git/mpd'
make: *** [all] Error 2
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
