On 2009/10/27 06:44, Alam Arias <alam....@gmail.com> wrote: > On Tue, Oct 27, 2009 at 1:34 AM, Max Kellermann <m...@duempel.org> wrote: > > What is the point of this patch? The patch description is missing, I > > shouldn't have to ask! > > > > It is a regression: each source should include its "own" header first, > > so the header is checked automatically by the compiler (checks for > > missing forward declarations and #includes). > > > > When I compile MPD with pulse support and -Werror, it errors out when > it define own version PA_CHECK_VERSION, then pulse/version.h's > defines it also well, it been like this since > b479a264b66a5cb74fc8424d7d47035fdfad8799 > > so this patch fix this check to define PA_CHECK_VERSION after it > including pulse's version.h
The proper solution would be to include pulse/version.h in pulse_output_plugin.h, instead of reordering the includes (which is a fragile workaround). ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
