On 2009/12/14 13:11, Albin Damlin <laederk...@gmail.com> wrote: > The attached patches supply two things: > > * Configuration support for the already in-place filter system > * A new filter which reroutes audio between channels
Good work! I have merged both features (folded the correction patches into the original two). Can you please do the following: - a large number of channels should be detected and reported. The signed char which is used allows a maximum of 127 channels. You could use audio_valid_channel_count() (current hard coded limit: 8 channels; will be extended as soon as somebody actually needs more) - you can use the pcm_buffer library for simpler buffer allocation. This is cheaper than realloc(), because realloc() has to copy the existing data, which we are not interested in. - use audio_format_frame_size() instead of audio_format_sample_size()*channels - use memcpy() instead of g_memmove(), because it is slightly faster and we know that the buffers don't overlap - use GError for error handling, instead of g_error(). Not all parts of MPD have been switched to GError yet, but filter_plugin.init() already has a GError** argument. Max ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
