On 2010/01/27 17:26, Tim Phipps <m...@phipps-hutton.freeserve.co.uk> wrote:
> Hi All,
> This bug is marked as fixed but the fix isn't in GIT trunk. Has it been
> forgotten? Can the patch be applied to GIT please? Below is a more up to
> date patch:
D'oh, looks like it got lost during the v0.15.x -> master branch
merge.
> -#include "replay_gain_info.h"
> +#include "replay_gain_config.h"
> + if (REPLAY_GAIN_ALBUM == replay_gain_mode) {
A decoder shouldn't import this header, and shouldn't use this global
variable. The replay gain mode may change at any time, and the
decision to drop all of the replay gain info just because there's no
data for the current mode may become obsolete then. The decoder
should always supply all data it has, and the MPD core shall decide
the rest.
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
