On 2010/05/17 12:15, Daniel Seuthe <daniel+...@seuthe.org> wrote: > Hello, > > The first allows to choose whether clipping prevention is used > while applying ReplayGain tags or not.
That changes the default behavior. Is that a good idea? I don't use replay gain myself, but there are lots of users caring about it. Since I don't use replay gain, I don't understand why this option is needed, could you explain? I'd like to include the explanation in the commit message. > The second pay attention to the ReplayGain mode ???auto??? and > the replay_gain_missing_preamp parameter inside of > decoder_replay_gain(). That includes an unrelated change - you moved the replay_gain_tuple_defined() check into replay_gain_tuple_scale(). I wouldn't do that, because that makes replay_gain_info.c depend on a global variable from replay_gain_config.c. Right now, replay_gain_info.c doesn't depend on anything. I removed that, and merged the rest. Thanks so far! ------------------------------------------------------------------------------ _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
