this is inconsistent with other commands (e.g. find) and seems wrong --
a song with no stickers attached is a perfectly valid state and an empty
list of stickers is also perfectly valid.
---
src/command.c | 10 +++-------
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/src/command.c b/src/command.c
index df0146c..781547b 100644
--- a/src/command.c
+++ b/src/command.c
@@ -1715,15 +1715,11 @@ handle_sticker_song(struct client *client, int argc,
char *argv[])
}
sticker = sticker_song_get(song);
- if (NULL == sticker) {
- command_error(client, ACK_ERROR_NO_EXIST,
- "no stickers found");
- return COMMAND_RETURN_ERROR;
+ if (sticker) {
+ sticker_print(client, sticker);
+ sticker_free(sticker);
}
- sticker_print(client, sticker);
- sticker_free(sticker);
-
return COMMAND_RETURN_OK;
/* set song song_id id key */
} else if (argc == 6 && strcmp(argv[1], "set") == 0) {
--
1.7.2.3
------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
