On Fri, Jan 28, 2011 at 21:29:42 +0100, Max Kellermann wrote: > On 2011/01/27 02:51, Dustin Puckett <puck...@pobox.com> wrote: > > I took my patch, and got it to work with a recent version of MPD > > about a month ago. Git has proven itself smarter than me, and I > > can't figure out the proper way to get a patch from it, but I've > > attached the output of 'git show', which I believe should be enough > > information. > > Hi Dustin, > > thanks, I have merged your patch into the master branch (for 0.17), > but I havn't tested it. I made it compile with two minor tweaks, and > I added a configure option (disabled by default).
Great, thanks. > Some obvious things from the very first rough code review: > > - need OpenSSL detection in configure.ac > > - need documentation in doc/user.xml I'll query Dustin about this, as the configuration is somewhat unclear to me. > > - no "goto", please! http://xkcd.com/292/ and think about the > children.. wrap stuff in a separate function, and clean up in the > caller. > > - maybe reuse code from server_socket.c? I'll look what I can do reagarding the above items. > > Hope somebody volunteers to work on it, just in case Dustin doesn't. > I don't have any Apple hardware, my personal interest in that plugin > is very low and I can't test. I'll have one AirPort express, and it seems like Dustin can test the plugin with multiple AirPort express devices. Regards, Tino ------------------------------------------------------------------------------ Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
