On 03/19/2011 03:46 PM, Avuton Olrich wrote:
Hello,
Compiling for a win32 target with roaraudio-0.4beta3 I get the following:
i586-mingw32msvc-gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I./src
-mms-bitfields -I/home/avuton/src/mpd-release-utils/build-dir/include/glib-2.0
-I/home/avuton/src/mpd-release-utils/build-dir/lib/glib-2.0/include
-DSYSTEM_CONFIG_FILE_LOCATION='"/home/avuton/src/mpd-release-utils/build-dir/etc/mpd.conf"'
-I/home/avuton/src/mpd-release-utils/build-dir/include
-I/home/avuton/src/mpd-release-utils/build-dir/include -Wall -Wextra
-Wmissing-prototypes -Wshadow -Wpointer-arith -Wstrict-prototypes
-Wcast-qual -Wwrite-strings -pedantic -O0 -ggdb3 -gstabs -pipe -MT
src/output/src_mpd-roar_plugin.o -MD -MP -MF
src/output/.deps/src_mpd-roar_plugin.Tpo -c -o
src/output/src_mpd-roar_plugin.o `test -f 'src/output/roar_plugin.c'
|| echo './'`src/output/roar_plugin.c
In file included from src/output/roar_output_plugin.h:25,
from src/output/roar_plugin.c:24:
/home/avuton/src/mpd-release-utils/build-dir/include/roaraudio.h:288:31:
warning: ISO C does not permit named variadic macros
/home/avuton/src/mpd-release-utils/build-dir/include/roaraudio.h:291:30:
warning: ISO C does not permit named variadic macros
/home/avuton/src/mpd-release-utils/build-dir/include/roaraudio.h:292:31:
warning: ISO C does not permit named variadic macros
/home/avuton/src/mpd-release-utils/build-dir/include/roaraudio.h:300:39:
warning: ISO C does not permit named variadic macros
src/output/roar_plugin.c:28:24: error: sys/socket.h: No such file or directory
src/output/roar_plugin.c:29:23: error: arpa/inet.h: No such file or directory
src/output/roar_plugin.c:30:19: error: netdb.h: No such file or directory
So, ifdef'ing that like httpd_output_plugin is done with libwrap then
shows this:
src/mixer/roar_mixer_plugin.c:31:23: error: sys/ioctl.h: No such file
or directory
Any love?
Thanks,
avuton
Hi, seems like the Roar plugin includes too many headers. Sorry about that.
Here's a patch that should build on Win32.
>From 12be57ef77d369620cdd9eafa286cc7037381e3e Mon Sep 17 00:00:00 2001
From: Themaister <mais...@archlinux.us>
Date: Sat, 19 Mar 2011 17:26:29 +0100
Subject: [PATCH] Remove unused headers in Roar plugin.
Should fix build errors for Win32.
---
src/mixer/roar_mixer_plugin.c | 4 ----
src/output/roar_plugin.c | 5 -----
2 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/src/mixer/roar_mixer_plugin.c b/src/mixer/roar_mixer_plugin.c
index 915f35e..636a9c0 100644
--- a/src/mixer/roar_mixer_plugin.c
+++ b/src/mixer/roar_mixer_plugin.c
@@ -27,10 +27,6 @@
#include <glib.h>
#include <assert.h>
-#include <sys/stat.h>
-#include <sys/ioctl.h>
-#include <fcntl.h>
-#include <errno.h>
#include <stdlib.h>
#include <unistd.h>
diff --git a/src/output/roar_plugin.c b/src/output/roar_plugin.c
index f12f795..f9d44a3 100644
--- a/src/output/roar_plugin.c
+++ b/src/output/roar_plugin.c
@@ -24,12 +24,7 @@
#include "roar_output_plugin.h"
#include <glib.h>
-#include <sys/types.h>
-#include <sys/socket.h>
-#include <arpa/inet.h>
-#include <netdb.h>
#include <stdint.h>
-#include <fcntl.h>
#include <unistd.h>
#include <stdlib.h>
#include <string.h>
--
1.7.4.1
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
