After the pointer to git interactive adding (and with additional help from google regarding hard/soft resets and stashes), I have split the patch into a "tidying" one and a "feature" one. I have added fuller commit messages, corrected the indentation error (was spaces instead of tabs in one place) and removed logging of unreachable code.
While googleing for generally accepted approaches for git commit messages, I realised the cause of confusion is that the web-based interface to git (at git.musicpd.org) shows only brief messages and I thought this was the whole commit message. I have since found that it is common for git-based systems to show the first line/paragraph of a commit message in summary lists and that the MPD commits are often more detailed. I have attempted to format my commit message in a way that is compatible with this approach. So my original (invalid) point was: MPD only has very brief messages, so why are you giving me such a hard time. But I now realise we were talking at cross purposes as MPD commit messages have detail where needed, just that I didn't see it (being new to git / MPD). I hope the new patches address your concerns. Let me know what you think. Steve. On 26 September 2011 06:49, Max Kellermann <m...@duempel.org> wrote: > On 2011/09/22 18:37, Steven Blackburn <st...@beeka.org> wrote: > > I take your point that the commit message could be more verbose, however > > most commit messages I make in my day job tend to read more like a > newspaper > > headline (rather than have the story with the details of how and why the > > change was done). The MPD git repo suggests similar usage. > > You're missing my point, let me try to clarify. > > You obviously thought your patch needs a long explanation, which is > why you wrote a lengthy email explaining it. > > My point is: if you think your patch needs a long explaination, then > the right place to do it is the patch description, not an accompanying > email. >
0002-Add-support-for-streaming-to-a-DLNA-client.patch
Description: Binary data
0001-Minor-logging-and-logic-tweaks-to-aid-debugging.patch
Description: Binary data
------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1
_______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
